This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] Consolidate partial symtab dependency reading
- From: Tom de Vries <tdevries at suse dot de>
- To: tromey at sourceware dot org, gdb-patches at sourceware dot org
- Date: Tue, 11 Feb 2020 20:34:39 +0100
- Subject: Re: [pushed] Consolidate partial symtab dependency reading
- References: <gerrit.1572228195000.I8151e05677794e90223edc1a4cb70f7f69137d46@gnutoolchain-gerrit.osci.io> <20200126234111.8019B20AF7@gnutoolchain-gerrit.osci.io>
On 27-01-2020 00:41, Sourceware to Gerrit sync (Code Review) wrote:
> Sourceware to Gerrit sync has submitted this change.
>
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/382
> ......................................................................
>
> Consolidate partial symtab dependency reading
>
> Most of the symbol readers have code to iterate over a partial symtabs
> dependencies, expanding each one and optionally printing a message.
> Now that the "second-stage" psymtab expansion is available as a
> method, these implementations can all be merged.
>
> This patch also changes a couple more warnings into assertions.
>
> gdb/ChangeLog
> 2020-01-26 Tom Tromey <tom@tromey.com>
>
> * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
> read_dependencies. Add assert.
> * psymtab.c (partial_symtab::read_dependencies): New method.
> * psympriv.h (struct partial_symtab) <read_dependencies>: New
> method.
> * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
> * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
> read_dependencies.
> * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
> Add assert.
This caused PR25534 - "[cc-with-dwz] FAIL: gdb.cp/m-static.exp: static
const int initialized elsewhere" (
https://sourceware.org/bugzilla/show_bug.cgi?id=25534 ).
Thanks,
- Tom