This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v2] [gdb/testsuite] Make inferior_exited_re match a single line
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Date: Tue, 4 Feb 2020 09:23:02 -0500
- Subject: [review v2] [gdb/testsuite] Make inferior_exited_re match a single line
- Auto-submitted: auto-generated
- References: <gerrit.1580742892000.Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/764
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
| --- gdb/testsuite/lib/gdb.exp
| +++ gdb/testsuite/lib/gdb.exp
| @@ -112,18 +112,18 @@ global env
| if ![info exists env(EXEEXT)] {
| set EXEEXT ""
| } else {
| set EXEEXT $env(EXEEXT)
| }
|
| set octal "\[0-7\]+"
|
| -set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)"
| +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r]*\\) exited)"
PS1, Line 120:
Eh, you're right, what I said didn't make sense. We escape the
opening bracket so it's not interpreted as a procedure call, so it can
be interpreted as a character group. But still, it's the same: if
there's an unescaped closing bracket that doesn't match any unescaped
opening bracket, tcl will treat it as a regular character.
|
| # A regular expression that matches a value history number.
| # E.g., $1, $2, etc.
| set valnum_re "\\\$$decimal"
|
| ### Only procedures should come after this point.
|
| #
| # gdb_version -- extract and print the version number of GDB
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333
Gerrit-Change-Number: 764
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Tue, 04 Feb 2020 14:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tom de Vries <tdevries@suse.de>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment