This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Adjust src-release.sh's getver due to gdbsupport's move to toplevel
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Cc: tom at tromey dot com, binutils at sourceware dot org
- Date: Wed, 29 Jan 2020 18:13:22 +0000
- Subject: Re: [PATCH] Adjust src-release.sh's getver due to gdbsupport's move to toplevel
- References: <20200128222514.10753-1-sergiodj@redhat.com>
On 1/28/20 10:25 PM, Sergio Durigan Junior wrote:
> diff --git a/src-release.sh b/src-release.sh
> index 92e92ac5d7..b3ca5ae137 100755
> --- a/src-release.sh
> +++ b/src-release.sh
> @@ -61,8 +61,8 @@ getver()
> $tool/common/create-version.sh $tool 'dummy-host' 'dummy-target' VER.tmp
> cat VER.tmp | grep 'version\[\]' | sed 's/.*"\([^"]*\)".*/\1/' | sed 's/-git$//'
> rm -f VER.tmp
> - elif test -f $tool/gdbsupport/create-version.sh; then
> - $tool/gdbsupport/create-version.sh $tool 'dummy-host' 'dummy-target' VER.tmp
> + elif test -f ./gdbsupport/create-version.sh; then
> + ./gdbsupport/create-version.sh $tool 'dummy-host' 'dummy-target' VER.tmp
It seems like this makes it so that the version.in fallback becomes unreachable.
./gdbsupport/create-version.sh is always going to exist irrespective of what
$tool is. Maybe it would be better to check that $tool is "gdb" instead.
Thanks,
Pedro Alves