This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix library segment-address for 64bit values
- From: Simon Marchi <simark at simark dot ca>
- To: Hannes Domani <ssbssa at yahoo dot de>, gdb-patches at sourceware dot org
- Date: Tue, 28 Jan 2020 13:47:36 -0500
- Subject: Re: [PATCH] Fix library segment-address for 64bit values
- References: <20200128173735.3584-1-ssbssa.ref@yahoo.de> <20200128173735.3584-1-ssbssa@yahoo.de>
On 2020-01-28 12:37 p.m., Hannes Domani via gdb-patches wrote:
> The address was written as a long value, but long is always a 32bit value
> on Windows.
Perhaps just mention: ", which lead to truncated addresses.".
The patch LGTM with that fixed, you can push it to both master and the gdb-9-branch.
Note that searching for '(long)' in that file reveals that there are probably more
instances of this problem.
Thanks,
Simon