This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Update comments about removed function
- From: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 24 Jan 2020 12:35:54 +0100
- Subject: Re: [PATCH] Update comments about removed function
- References: <20200123145519.197813-1-cbiesinger@chromium.org> <87sgk5pzru.fsf@tromey.com>
- Reply-to: Christian Biesinger <cbiesinger at google dot com>
On Thu, Jan 23, 2020 at 11:35 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> ">" == cbiesinger <cbiesinger@chromium.org> writes:
>
> >> From: Christian Biesinger <cbiesinger@google.com>
> >> regset_from_core_sections doesn't exist anymore; it has been replaced
> >> by the iterate_over_regset_sections gdbarch method. Update comments
> >> accordingly to not confuse readers.
>
> >> gdb/ChangeLog:
>
> >> 2020-01-23 Christian Biesinger <cbiesinger@google.com>
>
> >> * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
> >> Update comment.
> >> * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
> >> Likewise.
> >> * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
> >> * gdbcore.h (deprecated_add_core_fns): Update comment to point to
> >> the correct replacement (iterate_over_regset_sections).
> >> * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
> >> Update comment.
>
> Thanks. I think this one could be considered obvious, but FAOD it is ok.
Thanks, pushed. Will treat similar patches as obvious in the future.
Christian