This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 12/55] Introduce value_print_scalar_formatted
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simark at simark dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 23 Jan 2020 15:53:52 -0700
- Subject: Re: [PATCH 12/55] Introduce value_print_scalar_formatted
- References: <20191208182958.10181-1-tom@tromey.com> <20191208182958.10181-13-tom@tromey.com> <1567dc62-3968-3ec8-480c-9e3e4cd749e0@simark.ca>
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 2019-12-08 1:29 p.m., Tom Tromey wrote:
>> diff --git a/gdb/valprint.h b/gdb/valprint.h
>> index e4b90404fa2..f1c93aa26b6 100644
>> --- a/gdb/valprint.h
>> +++ b/gdb/valprint.h
>> @@ -141,6 +141,16 @@ extern void val_print_scalar_formatted (struct type *,
>> int,
>> struct ui_file *);
>>
>> +/* Print a scalar according to OPTIONS and SIZE on STREAM. Format i
>> + is not supported at this level.
Simon> There seems to be a typo above, "Format i".
It's copied from val_print_scalar_formatted. I think it refers to the
literal format 'i', so I changed it to read "Format 'i' is not..."
>> +
>> + This is how the elements of an array or structure are printed
>> + with a format. */
>> +
>> +extern void value_print_scalar_formatted (struct value *,
>> + const struct value_print_options *,
>> + int, struct ui_file *);
>> +
Simon> I think you should add the parameter names here, especially since the comment
Simon> refers to them.
I've done this.
Tom