This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] gdbserver: Make `make TAGS' actually work
- From: Tom Tromey <tom at tromey dot com>
- To: "Maciej W. Rozycki" <macro at wdc dot com>
- Cc: gdb-patches at sourceware dot org, Jim Wilson <jimw at sifive dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>, Palmer Dabbelt <palmer at dabbelt dot com>, Tom Tromey <tom at tromey dot com>, guoren at kernel dot org, lifang_xia at c-sky dot com, yunhai_shang at c-sky dot com, jiangshuai_li at c-sky dot com
- Date: Thu, 23 Jan 2020 14:31:08 -0700
- Subject: Re: [PATCH 3/4] gdbserver: Make `make TAGS' actually work
- References: <alpine.LFD.2.21.2001231412510.14118@redsun52.ssa.fujisawa.hgst.com> <alpine.LFD.2.21.2001231457290.14118@redsun52.ssa.fujisawa.hgst.com>
>>>>> "Maciej" == Maciej W Rozycki <macro@wdc.com> writes:
Maciej> error produced by `make TAGS' by making the list of sources processed
Maciej> match actual file locations and by moving host-specific object files
Maciej> listed in DEPFILES to nat/ or target/ subdirectories as appropriate so
Maciej> that the location of the corresponding source file can be mechanically
Maciej> determined.
Maciej> gdb/gdbserver/
Maciej> * Makefile.in (SFILES): Adjust paths to point to real files.
Maciej> (OBS): Move waitstatus.o to target/waitstatus.o.
Maciej> (TAGS): Transform paths appropriately.
Maciej> (%.o): Rename to...
Maciej> (nat/%.o): ... this pattern rule.
Maciej> (%.o): Rename to...
Maciej> (target/%.o): ... this pattern rule.
Maciej> * configure.srv: Adjust paths throughout to include nat/ prefix
Maciej> with the revant files.
Maciej> * configure.ac: Add `nat' and `target' to CONFIG_SRC_SUBDIR.
Maciej> * configure: Regenerate.
Thanks for the patch.
Maciej> NB SFILES is only maintained for the purpose of `make TAGS', so I could
Maciej> not persuade myself to put deliberate breakage there. I find it amazing
Maciej> and amusing nobody has noticed that for many years and just been blindly
Maciej> putting gibberish there.
LOL. Well, anything not tested will surely break :)
This looks ok to me.
Tom