This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][PATCH v2] Rebase executable to match relocated base address
- From: Tom Tromey <tom at tromey dot com>
- To: "Hannes Domani via gdb-patches" <gdb-patches at sourceware dot org>
- Cc: Hannes Domani <ssbssa at yahoo dot de>
- Date: Tue, 21 Jan 2020 15:38:26 -0700
- Subject: Re: [RFC][PATCH v2] Rebase executable to match relocated base address
- References: <20191223140825.5378-1-ssbssa.ref@yahoo.de> <20191223140825.5378-1-ssbssa@yahoo.de> <2139280774.21291807.1579206198152@mail.yahoo.com>
>>>>> "Hannes" == Hannes Domani via gdb-patches <gdb-patches@sourceware.org> writes:
>> But I'm not at all sure about my approach to forward the image base
>> via auxv data, but I needed a solution that worked for gdbserver as well.
I don't know about this either :(. Should it use the "library list
format" stuff instead? Or, how does it work on Linux?
>>
>> +static int
>> +win32_read_auxv (CORE_ADDR offset, unsigned char *myaddr, unsigned int len)
New functions need an introductory comment.
>>
>> +static enum target_xfer_status
>> +windows_xfer_auxv (gdb_byte *readbuf, ULONGEST offset, ULONGEST len,
>> + ULONGEST *xfered_len)
Here too.
>> + solib_target_so_ops.solib_create_inferior_hook =
>> + windows_solib_create_inferior_hook;
"=" should be after the line break.
Tom