This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] riscv: add gdbserver support

From: Simon Marchi <simark at simark dot ca>
To: "Maciej W. Rozycki" <macro at wdc dot com>, Jim Wilson <jimw at sifive dot com>
Cc: jiangshuai_li at c-sky dot com, Andrew Burgess <andrew dot burgess at embecosm dot com>, guoren at kernel dot org, gdb-patches at sourceware dot org, 夏立方 <lifang_xia at c-sky dot com>, yunhai_shang <yunhai_shang at c-sky dot com>
Date: Mon, 20 Jan 2020 20:31:31 -0500
Subject: Re: [PATCH] riscv: add gdbserver support
References: <00e401d5cb52$63a4d000$2aee7000$@c-sky.com> <CAFyWVaa7ADP_SmBVoan9AOkWK9parEz5EENZZL5vY+_GcD9SrA@mail.gmail.com> <alpine.LFD.2.21.2001202307240.15714@redsun52.ssa.fujisawa.hgst.com>

On 2020-01-20 6:33 p.m., Maciej W. Rozycki wrote:
>  Offhand I can see the proposal fails to implement XML register 
> descriptions, which I think every modern port is expected to do (we also 
> need to disallow non-XML-enabled RISC-V stubs in GDB proper, as we 
> discussed before; I fail to understand why it wasn't done right away with 
> the initial implementation, as it's quite straightforward and would have 
> set the policy for debug stubs right from the beginning).

I would also expect new ports to use XML target descriptions.  And I see
that there is already code in arch/riscv.c to build target descriptions based
on detected features... so should gdbserver use it?

Simon

[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/arch/riscv.c;h=a3ab8a92909f082754dfd6eb9a70f19153b8684f;hb=HEAD

Follow-Ups:
- Re: [PATCH] riscv: add gdbserver support
  - From: Maciej W. Rozycki
- Re: [PATCH] riscv: add gdbserver support
  - From: Andrew Burgess

References:
- [PATCH] riscv: add gdbserver support
  - From: jiangshuai_li
- Re: [PATCH] riscv: add gdbserver support
  - From: Jim Wilson
- Re: [PATCH] riscv: add gdbserver support
  - From: Maciej W. Rozycki

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]