This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix toplevel types with -fdebug-types-section

On 2020-01-18 1:53 p.m., Mark Williams wrote:
> Per https://sourceware.org/bugzilla/show_bug.cgi?id=24480 toplevel
> types were broken by
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=93b8bea4143cafae79076076c64aaa4c46a9b73c
> because it only set list_in_scope in start_sym_tab. With type-units,
> It also needs to be set when re-opening a symtab.
> 
> Mark
> 

Hi Mark,

Thanks for sending a patch.

Can you please put a bit more information in the commit message?  In particular:

- An illustration of the problem, and how to reproduce it
- Why/how this patch fixes the problem

There are good elements about that in the bug report discussions, it's just a matter
of synthesizing them in the commit message.

Thanks,

Simon
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]