Re: [PATCH v2 0/6] Move gdbsupport to top level

[Simon Marchi <simark at simark dot ca>]

On 2020-01-08 7:58 p.m., Tom Tromey wrote:
> Here is an update of the series to move gdbsupport to the top level.
> This is one step in the bigger projecct to move gdbserver to top
> level.
> 
> In this patch, gdbsupport is given its own configure script --
> however, gdbserver still builds its own copy.  gdb and gdbserver won't
> share a gdbsupport library until the final series.
> 
> This version of the patch fixes up the problems that Pedro pointed out
> in the shared nat/ and target/ code.  In particular, now they can
> simply rely on the shared config.h.  This is enforced by ensuring that
> the necessary defines are all available; the checker script I used to
> find the issues is provided in patch #5.
> 
> I wasn't able to send this through the buildbot.  I did test it on
> x86-64 Fedora 29.  I also build it using a mingw cross.
> 
> If you want to try it, it is on the branch
> submit/move-gdbsupport-to-top in my github.
> 
> Let me know what you think.
> 
> Tom

Hi Tom,

I think we are missing a dependency of the gdbsupport directory on the bfd
directory.  In a build from scratch, try to do "make all-gdbsupport".  You
should get:

make[2]: Entering directory '/home/simark/build/binutils-gdb/gdbsupport'
  CC       agent.o
In file included from /home/simark/src/binutils-gdb/gdbsupport/common-defs.h:109,
                 from /home/simark/src/binutils-gdb/gdbsupport/agent.c:20:
/home/simark/src/binutils-gdb/gdbsupport/common-types.h:35:10: fatal error: bfd.h: No such file or directory
   35 | #include "bfd.h"
      |          ^~~~~~~

Note that on my development machine, I didn't see this problem at first, but
then I realized that it was including /usr/include/bfd.h.  After I deleted it,
I got the error.

In the top-level Makefile, gdbsupport currently depends on configure-bfd.  I
suppose it should depend on all-bfd, since it needs for bfd.h to be generated?

Simon