This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 13 Jan 2020 10:30:51 -0700
- Subject: Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section
- References: <20200112201729.489317-1-simon.marchi@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> We are using alloca to hold the contents of a the core register
Simon> sections. These sections are typically fairly small, but there is no
Simon> realy guarantee, so I think it would be more reasonable to just use
Simon> dynamic allocation here.
I would be fine with simply avoiding alloca in most, or all, cases.
Simon> gdb/ChangeLog:
Simon> * corelow.c (core_target::get_core_register_section): Use
Simon> std::vector instead of alloca.
Looks reasonable to me.
Tom