This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/arm-tdep: the "strd rd, [sp, #-imm]!" is the part of function prologue.
- From: "chenzefeng (A)" <chenzefeng2 at huawei dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "brobecker at adacore dot com" <brobecker at adacore dot com>, "rearnsha at arm dot com" <rearnsha at arm dot com>, "palves at redhat dot com" <palves at redhat dot com>, "kevinb at redhat dot com" <kevinb at redhat dot com>, "andrew dot burgess at embecosm dot com" <andrew dot burgess at embecosm dot com>, "dje at google dot com" <dje at google dot com>, "simon dot marchi at polymtl dot ca" <simon dot marchi at polymtl dot ca>, "qiyao at sourceware dot org" <qiyao at sourceware dot org>, "Ulrich dot Weigand at de dot ibm dot com" <Ulrich dot Weigand at de dot ibm dot com>, "eliz at gnu dot org" <eliz at gnu dot org>, Nixiaoming <nixiaoming at huawei dot com>, "liucheng (G)" <liucheng32 at huawei dot com>, Zengweilin <zengweilin at huawei dot com>
- Date: Mon, 13 Jan 2020 13:00:22 +0000
- Subject: Re: [PATCH] gdb/arm-tdep: the "strd rd, [sp, #-imm]!" is the part of function prologue.
>>>>>> ">" == chenzefeng <chenzefeng2@huawei.com> writes:
>>> The "strd rd, [sp, #-imm]!" is the part of function prologue.
>>> Dump of assembler code for function __nanosleep:
>>> acc68: e16d41f8 strd r4, [sp, #-24]!
>>> acc6c: ee1d5f70 mrc 15, 0, r5, cr13, cr0, {3}
>>> acc70: e51534c0 ldr r3, [r5, #-1216]
>Thank you for the patch.
>gdb patches require a ChangeLog entry. See the GNU coding standards or
>the gdb contribution checklist for details.
Thank you for your review, I will give the another patch.
>https://sourceware.org/gdb/wiki/ContributionChecklist
>Also, do you have a copyright assignment in place?
>If not, then that's something to start.
>>> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
>>> ---
>>> gdb/arm-tdep.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>I don't know anything about ARM, really. I'm curious how this bug came
>up. Like, does the compiler ordinarily emit this kind of instruction in
>the prologue? Is it possible to write a test case for this, or does the
>patch fix some existing test failure?
When the bin is compiling with "-mtune=cortex-a15 -O2".
Yet, I have a test case, but I don't where to put the test case.
>thanks,
>Tom