This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/15] Add back declarations for _initialize functions

On 2020-01-10 1:43 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> I have just uploaded it to the "missing-declarations" branch on my github:
> Simon>   https://github.com/simark/binutils-gdb/tree/missing-declarations
> 
> Thanks.
> 
> Simon> I have updated the patches slightly to account for the new unittests.  So if you
> Simon> try to build, you'll stumble directly on the build error that made me give up:
> 
> I think just adding a few seemingly-redundant declarations is enough.
> At least, the appended made it compile for me.
> 
> "IP_AGENT_EXPORT_FUNC" takes care of the static/extern distinction already.

Thanks, that's really not bad indeed.  I've integrated your suggestion, and will send
a v2 right now.

Simon
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]