This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/2] Fix handling of null stap semaphores
- From: George Barrett <bob at bob131 dot so>
- To: Simon Marchi <simark at simark dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 11 Jan 2020 06:16:32 +1100
- Subject: Re: [PATCH v2 2/2] Fix handling of null stap semaphores
- Dkim-filter: OpenDKIM Filter v2.11.0 mail.bob131.so 9BDFD3E806
- References: <26056otsm6hu3octnbb1znmaooyq1x0&si&f67z1--1xu5_ssse/@mail.bob131.so> <8jh6lq70pfevy2fnv252japnkr1a_e946wms0723runb/plb._aa@mail.bob131.so> <9ee90aa7-eff9-feab-34e4-81cfc3547051@simark.ca>
On Thu, Jan 09, 2020 at 11:45:24PM -0500, Simon Marchi wrote:
> Hmm, I probably wouldn't use "xfail" here, since it's not like something is
> failing, it's just that this test doesn't apply to this configuration. What
> about just not mentioning at all when it does not apply?
Sounds fine to me.
> This test is a bit out of the ordinary, and I can imagine readers being
> confused as to why we are testing this. Could you please add a comment
> (just a short sentence) above this to hint to why we are doing this test?
Sure thing.
> Simon
Thanks