Re: [PATCH 2/2] [AArch64] Add more debugging output to aarch64_displaced_step_fixup

[Luis Machado <luis dot machado at linaro dot org>]

On 1/9/20 1:14 PM, Alan Hayward wrote:
> > On 30 Dec 2019, at 16:25, Luis Machado <luis.machado@linaro.org> wrote:
> >
> > While debugging the step-over-syscall problem, i wanted to see a bit more
> > debugging output to try to determine the root cause.
> >
> > This patch does this.
> >
> > gdb/ChangeLog:
> >
> > 2019-12-30  Luis Machado  <luis.machado@linaro.org>
> >
> > 	* aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
> > 	output.
> >
> > Signed-off-by: Luis Machado <luis.machado@linaro.org>
> > ---
> > gdb/aarch64-tdep.c | 24 +++++++++++++++++++++++-
> > 1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> > index a639b753cd..2d6c5a4bcb 100644
> > --- a/gdb/aarch64-tdep.c
> > +++ b/gdb/aarch64-tdep.c
> > @@ -3058,8 +3058,16 @@ aarch64_displaced_step_fixup (struct gdbarch *gdbarch,
> >    /* Fetch the current PC, after the displaced execution took place.  */
> >    regcache_cooked_read_unsigned (regs, AARCH64_PC_REGNUM, &pc);
> >
> > +  if (debug_displaced)
> > +    debug_printf ("displaced: PC after stepping: %s (was %s).\n",
> > +		  paddress (gdbarch, pc), paddress (gdbarch, to));
>
> Minor nit: Capital letter for the first word “Displaced”.
> Ditto for the rest of the patch.
> Otherwise ok.
> Once 1/2 is okayed, happy for updated version of this to be pushed without another review.

I'll get this fixed. Thanks!