This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/4] Use std::vector in abbrev_table_read_table

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
Date: Tue, 7 Jan 2020 22:52:27 -0500
Subject: Re: [PATCH 3/4] Use std::vector in abbrev_table_read_table
References: <20200107220754.24796-1-tromey@adacore.com> <20200107220754.24796-4-tromey@adacore.com>

On 2020-01-07 5:07 p.m., Tom Tromey wrote:
> This removes some manual memory management from
> abbrev_table_read_table, replacing it with a std::vector.
> 
> gdb/ChangeLog
> 2020-01-07  Tom Tromey  <tromey@adacore.com>
> 
> 	* dwarf2read.c (abbrev_table_read_table): Use std::vector.
> 
> Change-Id: I0b0e70ac2281d89a78f4d6a642700c9f0506871d

You can remove the ATTR_ALLOC_CHUNK definition.  Otherwise, this LGTM.

Simon

Follow-Ups:
- Re: [PATCH 3/4] Use std::vector in abbrev_table_read_table
  - From: Tom Tromey

References:
- [PATCH 0/4] Minor DWARF memory management cleanups
  - From: Tom Tromey
- [PATCH 3/4] Use std::vector in abbrev_table_read_table
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]