[PING][PATCH] Add type for $_tlb->process_environment_block->process_parameters

["Hannes Domani via gdb-patches" <gdb-patches at sourceware dot org>]

Ping.

Am Montag, 23. Dezember 2019, 17:10:38 MEZ hat Hannes Domani via gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben:

> The type then looks like this:
>
> (gdb) pt $_tlb->process_environment_block->process_parameters
> type = struct rtl_user_process_parameters {
>     DWORD32 maximum_length;
>     DWORD32 length;
>     DWORD32 flags;
>     DWORD32 debug_flags;
>     void *console_handle;
>     DWORD32 console_flags;
>     void *standard_input;
>     void *standard_output;
>     void *standard_error;
>     unicode_string current_directory;
>     void *current_directory_handle;
>     unicode_string dll_path;
>     unicode_string image_path_name;
>     unicode_string command_line;
>     void *environment;
>     DWORD32 starting_x;
>     DWORD32 starting_y;
>     DWORD32 count_x;
>     DWORD32 count_y;
>     DWORD32 count_chars_x;
>     DWORD32 count_chars_y;
>     DWORD32 fill_attribute;
>     DWORD32 window_flags;
>     DWORD32 show_window_flags;
>     unicode_string window_title;
>     unicode_string desktop_info;
>     unicode_string shell_info;
>     unicode_string runtime_data;
> } *
>
> It's mainly useful to get the current directory, or the full command line:
>
> (gdb) p $_tlb->process_environment_block->process_parameters->current_directory
> $1 = {
>   length = 26,
>   maximum_length = 520,
>   buffer = 0xe36c8 L"C:\\src\\tests\\"
> }
> (gdb) p $_tlb->process_environment_block->process_parameters->command_line
> $2 = {
>   length = 94,
>   maximum_length = 96,
>   buffer = 0xe32aa L"\"C:\\gdb\\build64\\gdb-git\\gdb\\gdb.exe\" access.exe"
> }
>
> gdb/ChangeLog:
>
> 2019-12-23  Hannes Domani  <ssbssa@yahoo.de>
>
>     * windows-tdep.c (windows_get_tlb_type):
>     Add rtl_user_process_parameters type.
> ---
> gdb/windows-tdep.c | 65 +++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 64 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c
> index bb69a79996..83a80f2f80 100644
> --- a/gdb/windows-tdep.c
> +++ b/gdb/windows-tdep.c
> @@ -114,6 +114,8 @@ windows_get_tlb_type (struct gdbarch *gdbarch)
>   struct type *peb_type, *peb_ptr_type, *list_type;
>   struct type *module_list_ptr_type;
>   struct type *tib_type, *seh_type, *tib_ptr_type, *seh_ptr_type;
> +  struct type *word_type, *wchar_type, *wchar_ptr_type;
> +  struct type *uni_str_type, *rupp_type, *rupp_ptr_type;
>
>   /* Do not rebuild type if same gdbarch as last time.  */
>   if (last_tlb_type && last_gdbarch == gdbarch)
> @@ -123,7 +125,15 @@ windows_get_tlb_type (struct gdbarch *gdbarch)
>                 1, "DWORD_PTR");
>   dword32_type = arch_integer_type (gdbarch, 32,
>                 1, "DWORD32");
> +  word_type = arch_integer_type (gdbarch, 16,
> +                1, "WORD");
> +  wchar_type = arch_integer_type (gdbarch, 16,
> +                  1, "wchar_t");
>   void_ptr_type = lookup_pointer_type (builtin_type (gdbarch)->builtin_void);
> +  wchar_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
> +                  TYPE_LENGTH (void_ptr_type) * TARGET_CHAR_BIT,
> +                  NULL);
> +  TYPE_TARGET_TYPE (wchar_ptr_type) = wchar_type;
>
>   /* list entry */
>
> @@ -168,6 +178,59 @@ windows_get_tlb_type (struct gdbarch *gdbarch)
>                 NULL);
>   TYPE_TARGET_TYPE (peb_ldr_ptr_type) = peb_ldr_type;
>
> +  /* struct UNICODE_STRING */
> +  uni_str_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> +  TYPE_NAME (uni_str_type) = xstrdup ("unicode_string");
> +
> +  append_composite_type_field (uni_str_type, "length", word_type);
> +  append_composite_type_field (uni_str_type, "maximum_length", word_type);
> +  append_composite_type_field_aligned (uni_str_type, "buffer",
> +                      wchar_ptr_type,
> +                      TYPE_LENGTH (wchar_ptr_type));
> +
> +  /* struct _RTL_USER_PROCESS_PARAMETERS */
> +  rupp_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> +  TYPE_NAME (rupp_type) = xstrdup ("rtl_user_process_parameters");
> +
> +  append_composite_type_field (rupp_type, "maximum_length", dword32_type);
> +  append_composite_type_field (rupp_type, "length", dword32_type);
> +  append_composite_type_field (rupp_type, "flags", dword32_type);
> +  append_composite_type_field (rupp_type, "debug_flags", dword32_type);
> +  append_composite_type_field (rupp_type, "console_handle", void_ptr_type);
> +  append_composite_type_field (rupp_type, "console_flags", dword32_type);
> +  append_composite_type_field_aligned (rupp_type, "standard_input",
> +                      void_ptr_type,
> +                      TYPE_LENGTH (void_ptr_type));
> +  append_composite_type_field (rupp_type, "standard_output", void_ptr_type);
> +  append_composite_type_field (rupp_type, "standard_error", void_ptr_type);
> +  append_composite_type_field (rupp_type, "current_directory", uni_str_type);
> +  append_composite_type_field (rupp_type, "current_directory_handle",
> +                  void_ptr_type);
> +  append_composite_type_field (rupp_type, "dll_path", uni_str_type);
> +  append_composite_type_field (rupp_type, "image_path_name", uni_str_type);
> +  append_composite_type_field (rupp_type, "command_line", uni_str_type);
> +  append_composite_type_field (rupp_type, "environment", void_ptr_type);
> +  append_composite_type_field (rupp_type, "starting_x", dword32_type);
> +  append_composite_type_field (rupp_type, "starting_y", dword32_type);
> +  append_composite_type_field (rupp_type, "count_x", dword32_type);
> +  append_composite_type_field (rupp_type, "count_y", dword32_type);
> +  append_composite_type_field (rupp_type, "count_chars_x", dword32_type);
> +  append_composite_type_field (rupp_type, "count_chars_y", dword32_type);
> +  append_composite_type_field (rupp_type, "fill_attribute", dword32_type);
> +  append_composite_type_field (rupp_type, "window_flags", dword32_type);
> +  append_composite_type_field (rupp_type, "show_window_flags", dword32_type);
> +  append_composite_type_field_aligned (rupp_type, "window_title",
> +                      uni_str_type,
> +                      TYPE_LENGTH (void_ptr_type));
> +  append_composite_type_field (rupp_type, "desktop_info", uni_str_type);
> +  append_composite_type_field (rupp_type, "shell_info", uni_str_type);
> +  append_composite_type_field (rupp_type, "runtime_data", uni_str_type);
> +
> +  rupp_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
> +                TYPE_LENGTH (void_ptr_type) * TARGET_CHAR_BIT,
> +                NULL);
> +  TYPE_TARGET_TYPE (rupp_ptr_type) = rupp_type;
> +
>
>   /* struct process environment block */
>   peb_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> @@ -178,7 +241,7 @@ windows_get_tlb_type (struct gdbarch *gdbarch)
>   append_composite_type_field (peb_type, "mutant", void_ptr_type);
>   append_composite_type_field (peb_type, "image_base_address", void_ptr_type);
>   append_composite_type_field (peb_type, "ldr", peb_ldr_ptr_type);
> -  append_composite_type_field (peb_type, "process_parameters", void_ptr_type);
> +  append_composite_type_field (peb_type, "process_parameters", rupp_ptr_type);
>   append_composite_type_field (peb_type, "sub_system_data", void_ptr_type);
>   append_composite_type_field (peb_type, "process_heap", void_ptr_type);
>   append_composite_type_field (peb_type, "fast_peb_lock", void_ptr_type);
> --
> 2.24.1