This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] GDB: Fix the overflow in addr/line_is_displayed()
- From: Pedro Alves <palves at redhat dot com>
- To: Shahab Vahedi <shahab dot vahedi at gmail dot com>, gdb-patches at sourceware dot org
- Cc: Shahab Vahedi <shahab at synopsys dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>, Claudiu Zissulescu <claziss at synopsys dot com>, Francois Bedard <fbedard at synopsys dot com>
- Date: Mon, 6 Jan 2020 19:55:43 +0000
- Subject: Re: [PATCH v3] GDB: Fix the overflow in addr/line_is_displayed()
- References: <45a718f7-e905-e7b1-1596-6ef6c4204176@redhat.com> <20200106142732.32733-1-shahab.vahedi@gmail.com>
Hi,
I merged this patch without waiting for copyright clearing, since the
amount of new copyrightable code is a few lines only IMO (the threshold
check), and also the current form of the patch was largely suggested
by me in a previous email.
For further fixes, I think it's better to wait until copyright
issues are cleared though.
> This commit avoids the segmentation faults with an early check:
>
> if (contet.size () < SCROLL_THRESHOLD)
> return false;
I fixed the "contet" typo before merging.
Thanks,
Pedro Alves