This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix a crash with a malformed PE header
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jon Turney <jon dot turney at dronecode dot org dot uk>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 02 Jan 2020 15:56:47 +0200
- Subject: Re: [PATCH] Fix a crash with a malformed PE header
- References: <20200102125405.11499-1-jon.turney@dronecode.org.uk>
> From: Jon Turney <jon.turney@dronecode.org.uk>
> Cc: Jon Turney <jon.turney@dronecode.org.uk>
> Date: Thu, 2 Jan 2020 12:54:05 +0000
>
> --- a/gdb/coff-pe-read.c
> +++ b/gdb/coff-pe-read.c
> @@ -441,6 +441,12 @@ read_pe_exported_syms (minimal_symbol_reader &reader,
> }
> }
>
> + if (expptr == 0)
> + {
> + /* no section contains export table rva */
> + return;
> + }
> +
Thanks. Would it make sense to produce some diagnostic output here,
when an appropriate debug-FOO option is set?