This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHv2] Fix setting breakpoints or stepping on line 65535
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Simon Marchi <simark at simark dot ca>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sun, 29 Dec 2019 21:24:08 +0000
- Subject: Re: [PATCHv2] Fix setting breakpoints or stepping on line 65535
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XJ/u1vZgDT8qf2MBvkU+kTNNVPhOD5fy9D/G7KzVdhA=; b=IQTxxDVI3AOa+rC+wHPD2ZA7Kc8ZaKXXqwayKWaTT+CxhkazzJ0IXTTwMqM9mnQtYqMSj7URZTD1pTXAcvF4WjxrYRpPB1RxXAFu+hiR58TLMZ7h1rcPzZQLevkDlatSXcqzPbkJMgW4dotH6XUR8utjzoxvSJ7OprRuAujKw4wVFhT+fk86MTLl+VJlIMzDXB8nYSuNQzA6ZkrdphE/gMPQlPzOmmMVA8dk2HorA17gblKE35ZPxLne1Oxr3AwxqjERVFfIjZiQHnuM4jO3TmS3/1ee9FzZECLtR7TtLF+RisKxyId+XG1nMMzdXhi8vgMjj1qq8WpFjPkiuECNMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4Z0bKZI8CtvKO6DXyPfrMAMr1E85mnq6URyA6Luk5D/klaBf0xqZBDkMq098VYDrGvg3P/mWbuCaFyyB91uWiLOQZG3afpicH2uJy3CxPkiN8vYb0lxnLqpgSt7JKuqFmTW99f//mIh6lhgsfkrTUY7iSYiSZ04iL7IkrDSVVTzYGOYsPLkvpTP3aT3PmbeTpyKcgDryNCIA+ILq/jHGejsYQowyWIZIgoyqZ+QRFLP5yKQtgpnOyvL/bl7cfitznu8WwR2Z23BGtd+VIgCIMuqckBhvEQtKgjBc5gJKd3DXQ6SNKpW7gVW9BgZ5MTOUkwRSZBpXm9CZlCN7fjTUw==
- References: <VI1PR03MB45286F546846FDB9CA9C2100E44B0@VI1PR03MB4528.eurprd03.prod.outlook.com> <20191201220818.GI3410@embecosm.com> <VI1PR08MB5325F950A716B0FFDF3809EFE4430@VI1PR08MB5325.eurprd08.prod.outlook.com> <b368f488-e6a6-b35d-a6f6-0f18be44ee00@simark.ca> <20191229203253.GP3865@embecosm.com> <5ea099d0-6fc4-c4b1-06b1-a0403f92eb7a@simark.ca>
On 12/29/19 9:41 PM, Simon Marchi wrote:
> On 2019-12-29 3:32 p.m., Andrew Burgess wrote:
>> I place more value on having tests and changes in the same commit - I
>> find it more useful the other way around, when I find some code I
>> don't understand and I figure out which commit it came from, having
>> the tests in the same commit means it is easy to know "this test"
>> should check "this code".
>>
>> If the test and changes are separate I have to do more work. Boo!
>>
>> For this reason, if you've not already pushed this patch, could you
>> collapse the test and change into a single commit please before
>> pushing.
>
> FWIW, that's my preference too.
>
Okay, will do.
Thanks!