This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] gdb: CTF support update
- From: Tom Tromey <tom at tromey dot com>
- To: Weimin Pan <weimin dot pan at oracle dot com>
- Cc: gdb-patches at sourceware dot org, tom at tromey dot com
- Date: Thu, 19 Dec 2019 13:27:24 -0700
- Subject: Re: [PATCH v5] gdb: CTF support update
- References: <1575597618-20336-1-git-send-email-weimin.pan@oracle.com>
>>>>> Weimin Pan <weimin.pan@oracle.com> writes:
> This patch addresses Tom Tromey's comments on the CTF reader:
> * Use the type-safe registry for ctf_file_key;
> * Drop "typedef" when defining "struct ctf_context";
> * Use ANOFFSET with SECT_OFF_TEXT to get the text base address;
Thanks for the patch.
> +struct ctf_fp_info
> + {
This brace should be in the leftmost column.
> + ctf_fp_info (ctf_file_t *cfp) : fp (cfp) {}
Single-argument constructors should be marked "explicit".
This patch is ok with these fixes. Thanks.
Tom