This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] [RFC] Don't block on finishing demangling msymbols
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Date: Fri, 13 Dec 2019 16:46:23 -0500
- Subject: [review] [RFC] Don't block on finishing demangling msymbols
- Auto-submitted: auto-generated
- References: <gerrit.1572481416000.I9d871917459ece0b41d31670b3c56600757aea66@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/463
......................................................................
Patch Set 1:
(1 comment)
| --- gdb/minsyms.c
| +++ gdb/minsyms.c
| @@ -335,18 +335,19 @@ lookup_minimal_symbol (const char *name, const char *sfile,
| {
| if (symbol_lookup_debug)
| {
| fprintf_unfiltered (gdb_stdlog,
| "lookup_minimal_symbol (%s, %s, %s)\n",
| name, sfile != NULL ? sfile : "NULL",
| objfile_debug_name (objfile));
| }
|
| + objfile->per_bfd->wait_for_msymbols ();
PS1, Line 344:
> WDYT?
Yeah -- that's essentially what the "memoized future" I linked to
does.
| /* Do two passes: the first over the ordinary hash table,
| and the second over the demangled hash table. */
| lookup_minimal_symbol_mangled (name, sfile, objfile,
| objfile->per_bfd->msymbol_hash,
| mangled_hash, mangled_cmp, found);
|
| /* If not found, try the demangled hash table. */
| if (found.external_symbol.minsym == NULL)
| {
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9d871917459ece0b41d31670b3c56600757aea66
Gerrit-Change-Number: 463
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 13 Dec 2019 21:46:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment