This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Share some Windows-related globals
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/710
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
LGTM, with nit below.
| --- gdb/nat/windows-nat.h
| +++ gdb/nat/windows-nat.h
| @@ -108,7 +150,19 @@ };
| +/* A vector of pending stops. Sometimes, Windows will report a stop
| + on a thread that has been ostensibly suspended. We believe what
| + happens here is that two threads hit a breakpoint simultaneously,
| + and the Windows kernel queues the stop events. However, this can
| + result in the strange effect of trying to single step thread A --
| + leaving all other threads suspended -- and then seeing a stop in
| + thread B. To handle this scenario, we queue all such "pending"
| + stops here, and then process them once the step has completed. See
| + PR gdb/22992. */
| +extern std::vector<pending_stop> pending_stops;
PS1, Line 159:
#include <vector>.
| +
| +
| /* Return the name of the DLL referenced by H at ADDRESS. UNICODE
| determines what sort of string is read from the inferior. Returns
| the name of the DLL, or NULL on error. If a name is returned, it
| is stored in a static buffer which is valid until the next call to
| get_image_name. */
| extern const char *get_image_name (HANDLE h, void *address, int unicode);
|
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3f861053e285afa3b3fff2d7892fdee2e59ab2c0
Gerrit-Change-Number: 710
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 29 Nov 2019 19:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment