[review v2] Share Windows thread-suspend and -resume code

["Pedro Alves (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/412
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

| --- gdb/nat/windows-nat.h
| +++ gdb/nat/windows-nat.h
| @@ -13,17 +13,19 @@ /* Internal interfaces for the Windows code
|     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
|     GNU General Public License for more details.
|  
|     You should have received a copy of the GNU General Public License
|     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
|  
|  #ifndef NAT_WINDOWS_NAT_H
|  #define NAT_WINDOWS_NAT_H
|  
| +#include <windows.h>

PS2, Line 22:

Nothing in this patch is adding code that requires this, so I wondered
why add it here.  After looking at the file, I realize that I think
this should have been added right when the nat/windows-nat.h was
created, due to use of DWORD, HANDLE, etc.

| +
|  /* Thread information structure used to track extra information about
|     each thread.  */
|  struct windows_thread_info
|  {
|    windows_thread_info (DWORD tid_, HANDLE h_, CORE_ADDR tlb)
|      : tid (tid_),
|        h (h_),
|        thread_local_base (tlb)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4e2be5d13faae083d9a83e65425c6c05d5d0e353
Gerrit-Change-Number: 412
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 29 Nov 2019 18:08:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment