[review v4] Introduce new layout code

["Andrew Burgess (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/367
......................................................................


Patch Set 4:

First, let me say, the new code ... massive improvement on what we have before, what I'm going to describe below certainly doesn't work on HEAD, so maybe you'd prefer to merge what you have and fix other issues later .... but I thought I'd mention what I spotted.

Start GDB running a test program, then `tui enable`.  (Note, I'm in a reasonably tall terminal for this test) You'll have the SRC/CMD window split.  Now make the CMD window bigger with `winheight cmd + ???` replace `???` with whatever number you need, and keep making the cmd window bigger until the SRC window reaches it minimum size, it should be upper board line, one line of source code, lower border line, then the location bar, then the CMD window.

Now `layout prev`.

Yeah, so the previous layout is REGS/ASM/CMD split.  When we switch to the previous layout GDB really needs to decrease the size of the CMD window to make space for new window at its minimum size I think.

Like I said, if you don't think this is worth fixing right now, then just let me know and I'll continue to review as we are right now - the current code already fixes a bunch of issues.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3a4cae666327b617d862aaa356f8179f945c6a4e
Gerrit-Change-Number: 367
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Sat, 23 Nov 2019 00:49:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment