This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Introduce win32_target_ops::decr_pc_after_break
- From: "Pedro Alves (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom Tromey <tromey at sourceware dot org>, gdb-patches at sourceware dot org
- Date: Thu, 21 Nov 2019 13:44:29 -0500
- Subject: [review] Introduce win32_target_ops::decr_pc_after_break
- Auto-submitted: auto-generated
- References: <gerrit.1572371871000.I2f412d4f597406d9045bcf5a18a205c6d8974db2@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/431
......................................................................
Patch Set 1: Code-Review+2
OK.
If ARM needed a value != 0, then this would need to be a function, since ARM/Thumb/Thumb-2 have breakpoint instructions with different widths. But it doesn't, so this is OK as is.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2f412d4f597406d9045bcf5a18a205c6d8974db2
Gerrit-Change-Number: 431
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 18:44:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment