[review] Add no-dist to gnulib configure

["Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/659
......................................................................


Patch Set 1:

(1 comment)

| --- gnulib/aclocal.m4
| +++ gnulib/aclocal.m4
| @@ -14,19 +14,9 @@ # PARTICULAR PURPOSE.
|  m4_ifndef([AC_CONFIG_MACRO_DIRS], [m4_defun([_AM_CONFIG_MACRO_DIRS], [])m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])])
|  m4_ifndef([AC_AUTOCONF_VERSION],
|    [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl
|  m4_if(m4_defn([AC_AUTOCONF_VERSION]), [2.69],,
|  [m4_warning([this file was generated for autoconf 2.69.
|  You have another version of autoconf.  It may work, but is not guaranteed to.
|  If you have problems, you may need to regenerate the build system entirely.
|  To do so, use the procedure documented by the package, typically 'autoreconf'.])])
|  
| -# po.m4 serial 24 (gettext-0.19)

PS1, Line 23:

> > So... this change seems unrelated. And unfortunately. when I run aclocal myself, it comes back. Do you have any idea what you did that makes aclocal not insert this block of code? (What's your gettext version?)
> 
> I don't see it coming back both when I run the update-gnulib.sh script and when I run aclocal by hand in 
> 
> I'm using autoconf and automake I built myself, and gettext 0.20.1 from the distro (Arch, and there doesn't seem to be any patches that would change this behavior).
> 
> Can you give details about your setup so that we can try it our our side?

I tried on Ubuntu 18.04, and see it too when using the distro
automake/autoconf.  But when building my own, it disappears.

The difference also appears to be because of these lines in
import/m4/gnulib-comp.mp4:

 272   m4_ifdef([AM_XGETTEXT_OPTION],
 273     [AM_][XGETTEXT_OPTION([--flag=error:3:c-format])
 274      AM_][XGETTEXT_OPTION([--flag=error_at_line:5:c-format])])

If I remove them and run aclocal again (even the Ubuntu-provided
version), I don't see this section added back to aclocal.m4.  So it
seems like aclocals from upstream and from Ubuntu don't agree in how
they handle using a macro name in m4_ifdef: does it consist in a usage
and it should be included in aclocal.mp4, or not?

| -dnl Copyright (C) 1995-2014, 2016 Free Software Foundation, Inc.
| -dnl This file is free software; the Free Software Foundation
| -dnl gives unlimited permission to copy and/or distribute it,
| -dnl with or without modifications, as long as this notice is preserved.
| -dnl
| -dnl This file can be used in projects which are not available under
| -dnl the GNU General Public License or the GNU Library General Public
| -dnl License but which still want to provide support for the GNU gettext
| -dnl functionality.

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9
Gerrit-Change-Number: 659
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 17 Nov 2019 18:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment