This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Add no-dist to gnulib configure
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom Tromey <tromey at sourceware dot org>, gdb-patches at sourceware dot org
- Cc: Christian Biesinger <cbiesinger at google dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Sun, 17 Nov 2019 01:10:02 -0500
- Subject: [review] Add no-dist to gnulib configure
- Auto-submitted: auto-generated
- References: <gerrit.1573851599000.I5224e18af9acd5284acb79d5756b0e84b00406e9@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/659
......................................................................
Patch Set 1:
(1 comment)
| --- gnulib/aclocal.m4
| +++ gnulib/aclocal.m4
| @@ -14,19 +14,9 @@ # PARTICULAR PURPOSE.
| m4_ifndef([AC_CONFIG_MACRO_DIRS], [m4_defun([_AM_CONFIG_MACRO_DIRS], [])m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])])
| m4_ifndef([AC_AUTOCONF_VERSION],
| [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl
| m4_if(m4_defn([AC_AUTOCONF_VERSION]), [2.69],,
| [m4_warning([this file was generated for autoconf 2.69.
| You have another version of autoconf. It may work, but is not guaranteed to.
| If you have problems, you may need to regenerate the build system entirely.
| To do so, use the procedure documented by the package, typically 'autoreconf'.])])
|
| -# po.m4 serial 24 (gettext-0.19)
PS1, Line 23:
So... this change seems unrelated. And unfortunately. when I run
aclocal myself, it comes back. Do you have any idea what you did that
makes aclocal not insert this block of code? (What's your gettext
version?)
| -dnl Copyright (C) 1995-2014, 2016 Free Software Foundation, Inc.
| -dnl This file is free software; the Free Software Foundation
| -dnl gives unlimited permission to copy and/or distribute it,
| -dnl with or without modifications, as long as this notice is preserved.
| -dnl
| -dnl This file can be used in projects which are not available under
| -dnl the GNU General Public License or the GNU Library General Public
| -dnl License but which still want to provide support for the GNU gettext
| -dnl functionality.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5224e18af9acd5284acb79d5756b0e84b00406e9
Gerrit-Change-Number: 659
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 17 Nov 2019 06:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment