This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at sourceware dot org>
- Date: Sat, 16 Nov 2019 17:32:12 -0500
- Subject: [review] gdb/testsuite: Merge whatis.exp and ctf-whatis.exp
- Auto-submitted: auto-generated
- References: <gerrit.1571177353000.I09e11c70f197b79d2b1e0ae8c86a21c622be6c51@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/123
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Andrew, is there anything holding back this series? I noted a minor comment, but in general I think it's nice.
| --- gdb/testsuite/gdb.base/whatis.exp
| +++ gdb/testsuite/gdb.base/whatis.exp
| @@ -586,0 +590,14 @@ if [compiler_supports_ctf_debug] {
| + lappend specs {ctf {"additional_flags=-gt"}}
| +}
| +
| +# Setup and run the test for each debug format.
| +foreach testspec $specs {
| + set prefix [lindex $testspec 0]
| + set opts [lindex $testspec 1]
| +
| + with_test_prefix $prefix {
| + remote_exec host "rm -rf [standard_output_file ${prefix}]"
PS1, Line 599:
Is this rm -rf necessary? I'm always a bit hesitant to use them in
scripts, since the consequences of making a mistake in the command can
be quite dramatic.
This comment applies to the previous patch too.
| + remote_exec host "mkdir -p [standard_output_file ${prefix}]"
| + do_test $prefix $opts
| + }
| +}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I09e11c70f197b79d2b1e0ae8c86a21c622be6c51
Gerrit-Change-Number: 123
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Sat, 16 Nov 2019 22:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment