This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v3] Introduce the tui_gen_win_info::min_height method
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Thu, 14 Nov 2019 17:51:20 -0500
- Subject: [review v3] Introduce the tui_gen_win_info::min_height method
- Auto-submitted: auto-generated
- References: <gerrit.1572212661000.Id33baffdf041fde072e15c1ff89b75f8b8118adb@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, andrew dot burgess at embecosm dot com, gdb-patches at sourceware dot org
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/365
......................................................................
Introduce the tui_gen_win_info::min_height method
This introduces a new method, tui_gen_win_info::min_height, to fetch
the minimum height of a window. This is used in the subsequent
unified layout patch.
2019-11-12 Tom Tromey <tom@tromey.com>
* tui/tui-stack.h (struct tui_locator_window) <min_height>:
Implement.
* tui/tui-regs.h (struct tui_data_item_window) <min_height>:
Implement.
* tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
method.
(struct tui_win_info) <min_height>: Implement.
Change-Id: Id33baffdf041fde072e15c1ff89b75f8b8118adb
---
M gdb/ChangeLog
M gdb/tui/tui-data.h
M gdb/tui/tui-regs.h
M gdb/tui/tui-stack.h
4 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0bc132b..0cc706a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,15 @@
2019-11-12 Tom Tromey <tom@tromey.com>
+ * tui/tui-stack.h (struct tui_locator_window) <min_height>:
+ Implement.
+ * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
+ Implement.
+ * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
+ method.
+ (struct tui_win_info) <min_height>: Implement.
+
+2019-11-12 Tom Tromey <tom@tromey.com>
+
* tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
(struct tui_win_info) <can_box>: Update.
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 7097a23..59c96b8 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -85,6 +85,9 @@
/* Compute the maximum height of this window. */
virtual int max_height () const = 0;
+ /* Compute the minimum height of this window. */
+ virtual int min_height () const = 0;
+
/* Return true if this window can be boxed. */
virtual bool can_box () const
{
@@ -184,6 +187,11 @@
int max_height () const override;
+ int min_height () const override
+ {
+ return MIN_WIN_HEIGHT;
+ }
+
/* Called after the tab width has been changed. */
virtual void update_tab_width ()
{
diff --git a/gdb/tui/tui-regs.h b/gdb/tui/tui-regs.h
index d476bcf..92df618 100644
--- a/gdb/tui/tui-regs.h
+++ b/gdb/tui/tui-regs.h
@@ -46,6 +46,11 @@
return 1;
}
+ int min_height () const override
+ {
+ return 1;
+ }
+
const char *name = nullptr;
/* The register number, or data display number. */
int item_no = -1;
diff --git a/gdb/tui/tui-stack.h b/gdb/tui/tui-stack.h
index dd9851b..27af5d2 100644
--- a/gdb/tui/tui-stack.h
+++ b/gdb/tui/tui-stack.h
@@ -42,6 +42,11 @@
return 1;
}
+ int min_height () const override
+ {
+ return 1;
+ }
+
void rerender () override;
/* Update the locator, with the provided arguments.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id33baffdf041fde072e15c1ff89b75f8b8118adb
Gerrit-Change-Number: 365
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: newpatchset