This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Share Windows thread-suspend and -resume code
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: gdb-patches at sourceware dot org
- Cc: Luis Machado <luis dot machado at linaro dot org>
- Date: Wed, 6 Nov 2019 14:14:18 -0500
- Subject: [review] Share Windows thread-suspend and -resume code
- Auto-submitted: auto-generated
- References: <gerrit.1572371871000.I4e2be5d13faae083d9a83e65425c6c05d5d0e353@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/412
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/412/1/gdb/nat/windows-nat.h
File gdb/nat/windows-nat.h:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/412/1/gdb/nat/windows-nat.h@43
PS1, Line 43:
26 | struct windows_thread_info
| ...
38 | void suspend ();
39 |
40 | /* Resume the thread if it has been suspended. */
41 | void resume ();
42 |
43 >
44 | /* The Win32 thread identifier. */
45 | DWORD tid;
46 |
47 | /* The handle to the thread. */
48 | HANDLE h;
> Spurious new line?
I fixed this locally.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4e2be5d13faae083d9a83e65425c6c05d5d0e353
Gerrit-Change-Number: 412
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 06 Nov 2019 19:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: comment