This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC PATCH] Support debuginfo and source file fetching via debuginfo server
- From: Simon Marchi <simark at simark dot ca>
- To: Aaron Merey <amerey at redhat dot com>, "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, Christian Biesinger via gdb-patches <gdb-patches at sourceware dot org>, Christian Biesinger <cbiesinger at google dot com>
- Date: Tue, 5 Nov 2019 00:35:31 -0500
- Subject: Re: [RFC PATCH] Support debuginfo and source file fetching via debuginfo server
- References: <20190820202809.25367-1-amerey@redhat.com> <CAPTJ0XEyOeZHUDr2zFovuSjMDxZ-XB1Wq1rftFE39Uiz9QFCmQ@mail.gmail.com> <87pnj6dl3k.fsf@tromey.com> <CAJDtP-QFDD91iH3ste2-tvtg8BjjqdD82NJEQQ9AWYwSc=VtRg@mail.gmail.com> <87sgn71ji6.fsf@tromey.com> <CAJDtP-Qfz52iG1H7mWdG25OP0oCc=trqYHv3_sZKZErXqAGrtQ@mail.gmail.com> <87lfsye5l5.fsf@redhat.com> <87bltrelab.fsf@redhat.com> <cdee1621-56dd-1779-9bc8-85c03a82561b@simark.ca> <20191104162616.GA13319@redhat.com> <CAJDtP-S6DpxEGG=T01h5_O8nbYYme1+ErJhcfJEomHBm2OObKQ@mail.gmail.com>
On 2019-11-04 8:59 p.m., Aaron Merey wrote:
> Attached is the updated debuginfo and source lookup code, using the
> callback idea that Simon suggested. Downloads are now cancelled upon
> SIGINT and the callback can be modified with code that prints progress
> messages (the a and b parameters in the callback represent the
> numerator and denominator of the download's completion fraction).
I took a peek at the debuginfod code and have one quick suggestion. It would
help to understand what is what if the debuginfod was subdivided in "client" and
"server" directories, and perhaps a "common" directory, if there's any code
to share between them.
Simon