This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Store objfiles on a std::list
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom Tromey <tromey at sourceware dot org>, gdb-patches at sourceware dot org
- Cc: Christian Biesinger <cbiesinger at google dot com>
- Date: Mon, 4 Nov 2019 00:34:00 -0500
- Subject: [review] Store objfiles on a std::list
- Auto-submitted: auto-generated
- References: <gerrit.1572831291000.Ib4430e3db6f9a390399924379a5c10426c514853@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/499
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/499/1/gdb/progspace.h
File gdb/progspace.h:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/499/1/gdb/progspace.h@179
PS1, Line 179:
137 | struct program_space
| ...
174 |
175 | /* Return true if there is more than one object file loaded; false
176 | otherwise. */
177 | bool multi_objfile_p () const
178 | {
179 > return objfiles_list.size () > 1;
180 | }
181 |
182 |
183 | /* Pointer to next in linked list. */
184 | struct program_space *next = NULL;
return !objfiles_list.empty ()?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib4430e3db6f9a390399924379a5c10426c514853
Gerrit-Change-Number: 499
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Mon, 04 Nov 2019 05:34:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment