This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v3] [gdb/symtab] Prefer var def over decl
- From: "Joel Brobecker (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at sourceware dot org>, Luis Machado <luis dot machado at linaro dot org>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Sun, 3 Nov 2019 20:11:31 -0500
- Subject: [review v3] [gdb/symtab] Prefer var def over decl
- Auto-submitted: auto-generated
- References: <gerrit.1571043046000.Id92326cb8ef9903b121ef9e320658eb565d0f5a9@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Joel Brobecker has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................
Patch Set 3:
> Patch Set 3:
>
> Thank you for doing this.
>
> The patch itself seems perfectly fine to me. I appreciated the comment
> and the test case -- those help a lot.
>
> However, I wonder why gdb is even making a symbol for a declaration in the
> first place. For some other kinds of declarations, gdb doesn't bother, so
> I was wondering if it's possible to simply ignore them in general.
Another way to ask the same question is what would it mean to have a type which has a declaration, but no definition. Wouldn't we still want to know about that type?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9
Gerrit-Change-Number: 29
Gerrit-PatchSet: 3
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 04 Nov 2019 01:11:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment