This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Make TUI resizing tests more robust
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/361
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Looks good to me. I did have one thought, but I don't know if it's worth doing anything with or not...
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/361/1/gdb/tui/tui-win.c
File gdb/tui/tui-win.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/361/1/gdb/tui/tui-win.c@700
PS1, Line 700:
677 | tui_async_resize_screen (gdb_client_data arg)
| ...
695 | tui_refresh_all_win ();
696 | tui_update_gdb_sizes ();
697 | if (resize_message)
698 | {
699 | static int count;
700 > printf_unfiltered ("@@ resize done %d\n", count);
701 | ++count;
702 | }
703 | tui_redisplay_readline ();
704 | }
705 | }
I wondered if it would be nice to print the size GDB thinks the terminal is as part of this message, then we could cross check this in the testsuite after we resize maybe? Not sure if this adds much value though...
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I420e0259cb99b21adcd28f671b99161eefa7a51d
Gerrit-Change-Number: 361
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 16:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment