[review] Share windows_thread_info between gdb and gdbserver

["Luis Machado (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Luis Machado has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

A couple nits, but otherwise LGTM.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h 
File gdb/nat/windows-nat.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h@1 
PS1, Line 1: 
1 > /* Internal interfaces for the Windows code
2 |    Copyright (C) 1995-2019 Free Software Foundation, Inc.
3 | 
4 |    This file is part of GDB.
5 | 
6 |    This program is free software; you can redistribute it and/or modify

Internal native interfaces maybe?


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h@35 
PS1, Line 35: 
24 | struct windows_thread_info
   | ...
30 |   HANDLE h;
31 | 
32 |   /* Thread Information Block address.  */
33 |   CORE_ADDR thread_local_base;
34 | 
35 >   /* Non zero if SuspendThread was called on this thread.  */
36 |   int suspended;
37 | 
38 | #ifdef _WIN32_WCE
39 |   /* The context as retrieved right after suspending the thread. */
40 |   CONTEXT base_context;

This discrepancy between Non zero here and Nonzero below caught my attention. Maybe we should fix it since we're adding new comments?



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9ba2d1b94be1550ea2e75e977d0808c7a27e2223
Gerrit-Change-Number: 407
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 03:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment