This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v2] Convert int to bool in agent.c
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Luis Machado <luis dot machado at linaro dot org>
- Date: Wed, 30 Oct 2019 21:30:56 -0400
- Subject: [review v2] Convert int to bool in agent.c
- Auto-submitted: auto-generated
- References: <gerrit.1572470558000.Icb28a65fcc8c7108bcd59287e6be66bf56f8ccb5@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Uploaded patch set 2.
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c
File gdb/gdbsupport/agent.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c@48
PS1, Line 48:
43 | }
44 |
45 | #define DEBUG_AGENT debug_agent_printf
46 |
47 | /* Global flag to determine using agent or not. */
48 > bool use_agent = 0;
49 |
50 | /* Addresses of in-process agent's symbols both GDB and GDBserver cares
51 | about. */
52 |
53 | struct ipa_sym_addresses_common
> Likewise make it "false"?
Oops, thanks. Fixed.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Icb28a65fcc8c7108bcd59287e6be66bf56f8ccb5
Gerrit-Change-Number: 462
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 01:30:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: comment