[review v2] Style diassembly in the TUI

["Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/179
......................................................................


Patch Set 2:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/179/2//COMMIT_MSG 
Commit Message:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/179/2//COMMIT_MSG@7 
PS2, Line 7: 
 2 | Author:     Tom Tromey <tom@tromey.com>
 3 | AuthorDate: 2019-10-21 11:21:14 -0600
 4 | Commit:     Tom Tromey <tom@tromey.com>
 5 | CommitDate: 2019-10-23 07:50:54 -0600
 6 | 
 7 > Style diassembly in the TUI
 8 | 
 9 | This patch changes the TUI disassembly window to style its contents.
10 | The styling should be identical to what is seen in the CLI.  This
11 | involved a bit of rearrangement, so that the source and disassembly
12 | windows could share both the copy_source_line utility function, and

> I noticed a typo here.  I'll fix this locally, but it seems too […]

Actually, I did point it out when reviewing v1.

Perhaps Gerrit doesn't make it clear enough when you have unresolved comments on prior patch versions, so they are easy to miss.  But that's where I usually look to see if there are any unresolved comments across all verions:

https://nova.polymtl.ca/~simark/ss/unresolved.png

Gerrit revisions are cheap, so I don't think it's a problem uploading a new one to fix a typo if you want.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I8722635eeecbbb1633d943a65b856404c2d467b0
Gerrit-Change-Number: 179
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 30 Oct 2019 19:30:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment