This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v2] [ARM, Thumb] Fix disassembling bug after reloading a symbol file
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Luis Machado <luis dot machado at linaro dot org>, gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Wed, 30 Oct 2019 11:15:16 -0400
- Subject: [review v2] [ARM, Thumb] Fix disassembling bug after reloading a symbol file
- Auto-submitted: auto-generated
- References: <gerrit.1572442722000.I22c3e6ebe9bfedad66d56fe9656994fa1761c485@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447
......................................................................
Patch Set 2:
(2 comments)
Thank you for the patch. I had one question that I think should
be answered before landing; plus one nit.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2//COMMIT_MSG@62
PS2, Line 62:
53 | (arm_bfd_data_key): ... this.
54 | (arm_find_mapping_symbol): Adjust access to new bfd_key-based
55 | data.
56 | (arm_record_special_symbol): Likewise.
57 |
58 | gdb/testsuite/ChangeLog:
59 |
60 | 2019-01-29 Luis Machado <luis.machado@linaro.org>
61 |
62 | * gdb.arch/pr25124.S: New file.
If there's a PR open for this, then each ChangeLog should
mention it, like "PR arch/25124". This syntax lets the
commit script log the commit in bugzilla.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2/gdb/arm-tdep.c
File gdb/arm-tdep.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2/gdb/arm-tdep.c@117
PS2, Line 117:
108 | symbol value (address). */
109 | std::unique_ptr<arm_mapping_symbol_vec[]> section_maps;
110 |
111 | /* For each corresponding element of section_maps above, is this vector
112 | sorted. */
113 | std::unique_ptr<bool[]> section_maps_sorted;
114 | };
115 |
116 | /* Per-bfd data used for mapping symbols. */
117 | static bfd_key<arm_per_bfd> arm_bfd_data_key;
I wonder if `arm_exidx_data_key` needs this treatment as well?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I22c3e6ebe9bfedad66d56fe9656994fa1761c485
Gerrit-Change-Number: 447
Gerrit-PatchSet: 2
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 30 Oct 2019 15:15:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment