This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] gdb: Introduce symbol_search_spec
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Cc: Christian Biesinger <cbiesinger at google dot com>, Tom Tromey <tromey at sourceware dot org>
- Date: Wed, 30 Oct 2019 10:30:59 -0400
- Subject: [review] gdb: Introduce symbol_search_spec
- Auto-submitted: auto-generated
- References: <gerrit.1571909344000.I488ab292a892d9e9e84775c632c5f198b6ad3710@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c
File gdb/symtab.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c@4359
PS1, Line 4359:
4350 | }
4351 |
4352 | /* Compare FILE against all the entries of FILENAMES. If BASENAMES is
4353 | non-zero compare only lbasename of FILENAMES. */
4354 |
4355 | static bool
4356 | file_matches (const char *file, const std::vector<const char *> &filenames,
4357 | bool basenames)
4358 | {
4359 | if (filenames.size () == 0)
filenames.empty()?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I488ab292a892d9e9e84775c632c5f198b6ad3710
Gerrit-Change-Number: 264
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2019 14:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment