This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] infcall, c++: allow more info to be computed for pass-by-reference va...
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tankut Baris Aktemur <tankut dot baris dot aktemur at intel dot com>, gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Tue, 29 Oct 2019 16:39:56 -0400
- Subject: [review] infcall, c++: allow more info to be computed for pass-by-reference va...
- Auto-submitted: auto-generated
- References: <gerrit.1571406803000.Ib1c1f87f2490a5737c469f7b7185ddc7f6a164cb@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/136
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Just a nit. But otherwise LGTM, honorable mention for the nice comments!
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/136/1/gdb/language.c
File gdb/language.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/136/1/gdb/language.c@671
PS1, Line 671:
663 |
664 | /* Return a default struct that provides pass-by-reference information
665 | about the given TYPE. Languages should update the default values
666 | as appropriate. */
667 |
668 | struct language_pass_by_ref_info
669 | default_pass_by_reference (struct type *type)
670 | {
671 | struct language_pass_by_ref_info info;
672 | return info;
Nit: that could be just
return {};
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib1c1f87f2490a5737c469f7b7185ddc7f6a164cb
Gerrit-Change-Number: 136
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 20:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment