This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] testsuite, cp: increase the coverage of testing pass-by-ref arguments
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tankut Baris Aktemur <tankut dot baris dot aktemur at intel dot com>, gdb-patches at sourceware dot org
- Date: Mon, 28 Oct 2019 18:06:38 -0400
- Subject: [review] testsuite, cp: increase the coverage of testing pass-by-ref arguments
- Auto-submitted: auto-generated
- References: <gerrit.1571406803000.Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/142
......................................................................
Patch Set 1:
Thank you for the patch.
This looks pretty good to me.
I wanted to verify that the tests failed without your series.
Also, I think the generated file could just be generated each test run.
Then this wouldn't need a special mode to regenerate the file.
I think there are other tests that do this already.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6
Gerrit-Change-Number: 142
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 22:06:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment