This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [review] Make TUI resizing tests more robust
> Date: Sun, 27 Oct 2019 17:44:24 -0400
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/361
> ......................................................................
>
> gdb/ChangeLog
> 2019-10-27 Tom Tromey <tom@tromey.com>
>
> * tui/tui-win.c (resize_message): New global.
> (show_tui_resize_message): New function.
> (tui_async_resize_screen): Print message if requested.
> (_initialize_tui_win): Add tui-resize-message setting.
> * NEWS: Add entry for new commands.
>
> gdb/doc/ChangeLog
> 2019-10-27 Tom Tromey <tom@tromey.com>
>
> * gdb.texinfo (Maintenance Commands): Document new command.
>
> gdb/testsuite/ChangeLog
> 2019-10-27 Tom Tromey <tom@tromey.com>
>
> * lib/tuiterm.exp (_accept): Add wait_for parameter. Check output
> after any command. Expect prompt after WAIT_FOR is seen.
> (enter_tui): Enable resize messages.
> (command): Expect command in output.
> (get_line): Avoid error when cursor appears to be off-screen.
> (dump_screen): Include screen size in title.
> (_do_resize): New proc, from "resize".
> (resize): Rewrite. Do resize in two steps.
> * gdb.tui/empty.exp (layouts): Fix entries.
> (check_boxes): Remove xfail.
> (check_text): Dump screen on failure.
>
> Change-Id: I420e0259cb99b21adcd28f671b99161eefa7a51d
> ---
> M gdb/ChangeLog
> M gdb/NEWS
> M gdb/doc/ChangeLog
> M gdb/doc/gdb.texinfo
> M gdb/testsuite/ChangeLog
> M gdb/testsuite/gdb.tui/empty.exp
> M gdb/testsuite/lib/tuiterm.exp
> M gdb/tui/tui-win.c
> 8 files changed, 168 insertions(+), 48 deletions(-)
The documentation parts of this patch are OK.
P.S. I'm sorry, I tried to use the Gerrit UI in a browser, but
failed. The wiki gives instructions, but they don't seem to work: it
mentions the Reply button which I don't see, and in general when I
look at the interface presented by going to the above URL, I'm lost
and don't know how to proceed.
All I wanted is to say the above: that the documentation parts are OK.