This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Remove unused includes in infcmd.c and infrun.c
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Mon, 28 Oct 2019 09:38:37 -0400
- Subject: [review] Remove unused includes in infcmd.c and infrun.c
- Auto-submitted: auto-generated
- References: <gerrit.1572157288000.I5e25af54ecd2235960c4127add8f604ddbb19153@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/322
......................................................................
Patch Set 1:
> I haven't tried, but we might need to be a bit careful when preprocessor #ifs or #ifdefs are involved. Since it compiles a particular configuration, as described in a compile_commands.json file, I would guess that it only considers what's kept by the preprocessor in this particular configuration. So it could tell you to remove an include that's actually needed when the other branch of the #ifdef is taken. Though maybe in that case, the include file should be conditionally included, using that same condition.
Yeah, I that would be good as well, just because it makes the connection more
explicit.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e25af54ecd2235960c4127add8f604ddbb19153
Gerrit-Change-Number: 322
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 28 Oct 2019 13:38:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment