This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[review] Remove unused includes in ada-*.c files


Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/323
......................................................................


Patch Set 1:

(2 comments)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/323/1/gdb/ada-valprint.c 
File gdb/ada-valprint.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/323/1/gdb/ada-valprint.c@59 
PS1, Line 59: 
50 | 
51 | /* Assuming TYPE is a simple array type, prints its lower bound on STREAM,
52 |    if non-standard (i.e., other than 1 for numbers, other than lower bound
53 |    of index type for enumerated type).  Returns 1 if something printed,
54 |    otherwise 0.  */
55 | 
56 | static int
57 | print_optional_low_bound (struct ui_file *stream, struct type *type,
58 | 			  const struct value_print_options *options)
59 | {

This is a test comment (2).


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/323/1/gdb/ada-valprint.c@100 
PS1, Line 100: 
 57 | print_optional_low_bound (struct ui_file *stream, struct type *type,
    | ...
 91 |     case TYPE_CODE_BOOL:
 92 |     case TYPE_CODE_CHAR:
 93 |       if (low_bound == 0)
 94 | 	return 0;
 95 |       break;
 96 |     case TYPE_CODE_ENUM:
 97 |       if (low_bound == TYPE_FIELD_ENUMVAL (index_type, 0))
 98 | 	return 0;
 99 |       break;
100 |     case TYPE_CODE_UNDEF:

This is another test comment (2).



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I07c2f2237ef0ed5fd9aa855d33711d780794fce2
Gerrit-Change-Number: 323
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 27 Oct 2019 15:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]