This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v3] Don't make an extra copy + allocation of the demangled name
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, Luis Machado <luis dot machado at linaro dot org>
- Date: Fri, 25 Oct 2019 14:24:46 -0400
- Subject: [review v3] Don't make an extra copy + allocation of the demangled name
- Auto-submitted: auto-generated
- References: <gerrit.1571352433000.Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132
......................................................................
Patch Set 3: Code-Review+2
> Patch Set 3:
>
> (1 comment)
>
> Thank you. This looks good, but I think free_demangled_name_entry needs to
> be updated to destroy the new member.
Oh, never mind -- I was misreading that function!
I see now it calls the full object's destructor, which will
do the right thing.
This patch is ok with the formatting nit fixed. No need to re-review.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0
Gerrit-Change-Number: 132
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:24:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment