This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v4] Load system gdbinit files from a directory
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at sourceware dot org>, Tom de Vries <tdevries at suse dot de>
- Date: Thu, 24 Oct 2019 14:59:52 -0400
- Subject: [review v4] Load system gdbinit files from a directory
- Auto-submitted: auto-generated
- References: <gerrit.1570968845000.If233859ecc21bc6421d589b37cd658a3c7d030f2@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26
......................................................................
Patch Set 4:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c
File gdb/main.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@268
PS3, Line 268: if (dir != nullptr)
> Yes, I wanted to save an indentation level. […]
Well, I think it looks a bit unnatural, but I don't have a strong opinion. If we're starting to have too many indentation levels, it sometimes mean it's time to split to a new function.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2
Gerrit-Change-Number: 26
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 24 Oct 2019 18:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment