This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v2] [gdb/testsuite] Add -wrap pattern flag to gdb_test_multiple
- From: "Luis Machado (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Thu, 24 Oct 2019 11:36:57 -0400
- Subject: [review v2] [gdb/testsuite] Add -wrap pattern flag to gdb_test_multiple
- Auto-submitted: auto-generated
- References: <gerrit.1571045169000.Ie42c97d5ab7acf6db351299ccd23a83540fe6e1a@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/36
......................................................................
Patch Set 2:
> Patch Set 1:
>
> > Patch Set 1: Code-Review+1
> >
> > This looks useful, though i don't quite like the flag name. It seems to simplify the pattern matching, so -simple or -short comes to mind, which may not be much better.
> >
>
> I've gone with -wrap (a suggestion by Andrew).
>
> > In any case, the change looks OK to me.
> >
> > I also noticed a few other testcases that would benefit from such simplification:
> >
> > gdb.cp/local-static.exp
> > gdb.reverse/solib-reverse.exp
> > gdb.reverse/solib-precsave.exp
> > gdb.reverse/sigall-precsave.exp
> > gdb.reverse/sigall-reverse.exp
> > gdb.reverse/until-reverse.exp
> > gdb.reverse/until-precsave.exp
> > gdb.rust/simple.exp
> > gdb.base/restore.exp
> > gdb.arch/amd64-init-x87-values.exp
>
> Indeed, but for this commit I'm targeting just a single demonstrator test-case.
No worries. We can fix it later.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie42c97d5ab7acf6db351299ccd23a83540fe6e1a
Gerrit-Change-Number: 36
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Thu, 24 Oct 2019 15:36:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment