This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v3] [gdb/symtab] Prefer var def over decl
- From: "Tom de Vries (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: gdb-patches at sourceware dot org
- Cc: Luis Machado <luis dot machado at linaro dot org>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Wed, 23 Oct 2019 12:29:44 -0400
- Subject: [review v3] [gdb/symtab] Prefer var def over decl
- Auto-submitted: auto-generated
- References: <gerrit.1571043046000.Id92326cb8ef9903b121ef9e320658eb565d0f5a9@gnutoolchain-gerrit.osci.io>
- Reply-to: tdevries at suse dot de, andrew dot burgess at embecosm dot com, luis dot machado at linaro dot org, gdb-patches at sourceware dot org
Tom de Vries has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................
Patch Set 3:
(2 comments)
Thanks for the comments, updated the patch set.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c
File gdb/block.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c@737
PS2, Line 737: /* Return true if symbol A is a better match than symbol B for DOMAIN. */
> The comment is a bit misleading. […]
Done
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp
File gdb/testsuite/gdb.dwarf2/varval.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp@209
PS2, Line 209:
> Spurious new line?
Done